TheAMM / mpv_thumbnail_script

A Lua script to show preview thumbnails in mpv's OSC seekbar, sans external dependencies
GNU General Public License v3.0
677 stars 68 forks source link

Thumbnailing is not working anymore on Windows mpv build #60

Open amayra opened 4 years ago

amayra commented 4 years ago

i try new build andi get this error

[   0.006][w][cplayer] Warning: option --o is deprecated and might be removed in the future (lack of maintainer).
[   0.006][f][cplayer] Error parsing commandline option o: option requires parameter
[   0.006][w][cplayer] Make sure you're using e.g. '--o=value' instead of '--o value'.
[   0.006][i][cplayer] Exiting... (Fatal error)

and console output is

PS C:\Program Files\mpv player> mpv poki.mkv
[mpv_thumbnail_script_client_osc] The 'tracks-changed' event is deprecated and will be removed.
 (+) Video --vid=1 (*) (h264 1280x720 24.000fps)
 (+) Audio --aid=1 --alang=eng (*) (aac 2ch 48000Hz)
 (+) Subs  --sid=1 (*) (ass)
AO: [wasapi] 48000Hz stereo 2ch float
VO: [gpu] 1280x720 yuv420p
AV: 00:00:00 / 00:24:35 (0%) A-V:  0.000
[mpv_thumbnail_script_client_osc] The 'tick' event is deprecated and will be removed.
AV: 00:00:00 / 00:24:35 (0%) A-V:  0.000
[mpv_thumbnail_script_server] Thumbnailing command failed!
[mpv_thumbnail_script_server] mpv process error: nil
[mpv_thumbnail_script_server] Process stdout:
[mpv_thumbnail_script_server] Debug log: C:\Program Files\mpv player\portable_config\watch_later\poki-467305219\000000.bgra.log
[mpv_thumbnail_script_server] Output file missing! C:\Program Files\mpv player\portable_config\watch_later\poki-467305219\000000.bgra
ghost commented 4 years ago

I'm getting almost the exact same error...

ghost commented 4 years ago

Same error here, there are deprecated commands in the code, maybe this is the problem: tracks-changed event tick event The problem is that mpv documentation says to use mpv_observe_property() instead, but i found no description!!

amayra commented 4 years ago

I try to modified too but didn't work for me

ghost commented 4 years ago

I try to modified too but didn't work for me

I found a solution, at least for me: https://github.com/TheAMM/mpv_thumbnail_script/issues/53

ghost commented 4 years ago

@Maikurosofuto thanks for sharing the solution !!! it works !!