search

TheAMM / mpv_thumbnail_script

A Lua script to show preview thumbnails in mpv's OSC seekbar, sans external dependencies
GNU General Public License v3.0
683 stars 68 forks source link

Doesn't work but I found the solution! #66

Open sdsaati opened 4 years ago

sdsaati commented 4 years ago

Line 525 of mpv_thumbnail_script_server.lua, should be ("--o=%s"):format(output_path) instead of "--o", output_path, because recently if you don't do it, you will get this error:

[ 0.004][f][cplayer] Error parsing commandline option o: option requires parameter

ManuLinares commented 4 years ago

Thanks

InigoGutierrez commented 4 years ago

This fixed it for me! It seems a (different) (also working for me) fix is already in the source code in master branch, but not in the releases page linked in the README.

turmoggy commented 4 years ago

Works with mpv, but not mpv.net.

eyirkce commented 4 years ago

thanks

sdsaati commented 4 years ago

your welcome :)

emk2203 commented 4 years ago

Now if only that cure would find its way back into the release...

(It's still giving this error as of November 11, 2020).

sdsaati commented 4 years ago

@emk2203, Hi, can you please give me the exact error you get?

snowman commented 3 years ago

How about close this issue?

This problem occurs because downloading the legacy script mpv_thumbnail_script_server.lua from https://github.com/TheAMM/mpv_thumbnail_script/releases lastest released from "Feb 8, 2018".

This was fixed at commit 682becf5b5115c2a206b4f0bdee413d4be8b5bef at "Jan 17, 2020".

Steps to get the lastest mpv_thumbnail_script_server.lua and mpv_thumbnail_script_client_osc.lua:

$ git clone https://github.com/TheAMM/mpv_thumbnail_script
$ cd mpv_thumbnail_script
$ make
./concat_files.py -r cat_server.json
Concatenated source files to 'mpv_thumbnail_script_server.lua'
./concat_files.py -r cat_osc.json
Concatenated source files to 'mpv_thumbnail_script_client_osc.lua'
kimabjorkede commented 3 years ago

How about close this issue?

This problem occurs because downloading the legacy script mpv_thumbnail_script_server.lua from https://github.com/TheAMM/mpv_thumbnail_script/releases lastest released from "Feb 8, 2018".

This was fixed at commit 682becf at "Jan 17, 2020".

Steps to get the lastest mpv_thumbnail_script_server.lua and mpv_thumbnail_script_client_osc.lua:

$ git clone https://github.com/TheAMM/mpv_thumbnail_script
$ cd mpv_thumbnail_script
$ make
./concat_files.py -r cat_server.json
Concatenated source files to 'mpv_thumbnail_script_server.lua'
./concat_files.py -r cat_osc.json
Concatenated source files to 'mpv_thumbnail_script_client_osc.lua'

Why not create a new release?

ronilaukkarinen commented 3 years ago

I'm another fool who downloaded from releases... please update the release, thanks.

ghost commented 2 years ago

not working for me