TheAMM / mpv_thumbnail_script

A Lua script to show preview thumbnails in mpv's OSC seekbar, sans external dependencies
GNU General Public License v3.0
679 stars 68 forks source link

Add absurdly low performance warning to front page! #79

Open StacktraceException opened 3 years ago

StacktraceException commented 3 years ago

Running this shit on 16 core Ryzen 9 5900HX with 32GB of ram, uses up all CPU cores 100% and all of the 32GB of RAM. For at least minutes, this is fucking unusable, unless maybe you want to prerender the thumbnails for later.

Wasted two hours for this thankfully free but time costing software, (fixed your lacking equals sign error, FFS how long does it take to merge this, other people have requested this for ages..., reducing cpu core count to 1 in your code also does nothing, still all cores are used up on Windows, still respect for writing Lua code, I dont even know how to write Hello World in it.)

End of rant, thank you for reading and having good intentions/sharing

escapezn commented 3 years ago

Try this https://github.com/deus0ww/mpv-conf/blob/master/scripts/Thumbnailer.lua. It has much better performance.