TheAcharya / MarkerData

The avant-garde Marker extraction application crafted for Final Cut Pro
https://markerdata.theacharya.co
MIT License
22 stars 1 forks source link

Roles's selections are not synced when using Workflow Extension #65

Closed IAmVigneswaran closed 2 months ago

IAmVigneswaran commented 2 months ago

@milanvarady Using the last build.

Role's selection is not saved/respected when using the Workflow Extension.

https://github.com/TheAcharya/MarkerData/assets/118706051/8045b23a-d323-4db5-8178-e4ac7f595199

milanvarady commented 2 months ago

Can you try again with MarkersExtractor 0.3.4? Maybe it fixes the issue.

IAmVigneswaran commented 2 months ago

Can you try again with MarkersExtractor 0.3.4? Maybe it fixes the issue.

I have just tried it. I have even change the version from 0.3.3 to 0.3.4 https://github.com/TheAcharya/MarkerData/commit/6b2ed0069d3b296d8f8252c71523e0322afb98e2

I remember a few builds back (Last month or so), we were able to "Remember" Roles selection setting when extracting via Workflow Extension.

I remember pervasively, the behaviour was when we drag the timeline to the Role's Tab within Workflow Extension, Role's Tab within main application's general tab would be populated. Now, it is not the case.

Workflow Extension

milanvarady commented 2 months ago

I updated the roles sync logic, so this should be fixed now. Please check if it works on your end @IAmVigneswaran.

IAmVigneswaran commented 2 months ago

@milanvarady I just test with the latest test build.

It is not working. The behaviour is still the same. When I drag and drop the timeline into the Workflow Extension's Roles Tab, it is not updated in the General's Roles Tab.

The Refresh button seems to be broken. Previously I recall, clicking the Refresh button would update General's Roles Tab. Now Refresh button just clears the list in Workflow Extension's Roles Tab.

milanvarady commented 2 months ago

@IAmVigneswaran I have tested it again, and it works for me every time. I don't know what could be the issue. Sync happens when the window gets focused. The extraction has the correct roles.

In the video I have disabled all roles so there is no output.

https://github.com/TheAcharya/MarkerData/assets/61704770/08db0e5b-5617-403c-bc7d-d1e32cadce14

IAmVigneswaran commented 2 months ago

@milanvarady Using the latest build. Here is my screen recording.

As you can see, for some strange reason, I can't able to get the Roles to Sync with the Main App from the Workflow Extension.

You mentioned Sync happens when the window gets focused. As you can see, in my video, even if I get the window to get focus, nothing happens.

https://github.com/TheAcharya/MarkerData/assets/118706051/2ecf49a9-4600-495d-990e-9aae7feb6c7c

Clicking the Refresh button makes the roles list to clear or disappear.

Is there anything that I am not doing correctly?

Somethings to note.

My Marker Data Cache folder is empty.


If I were to drag the timeline from FCP directly to the Main App's Roles Tabs, the roles are retrieved. But, if I were to drag the timeline back to the Workflow Extension, the roles are not synced when clicking the Refresh button.

https://github.com/TheAcharya/MarkerData/assets/118706051/27df0422-2ccb-4299-aced-815463021a5a

Is there a way to debug this issue?

From my debug logs

[29/04/2024, 9:07 AM] [OpenEventHandler] Open event handler setup DONE
[29/04/2024, 9:07 AM] [OpenEventHandler] Open event handler setup DONE
[29/04/2024, 9:17 AM] [OpenEventHandler] Open event handler setup DONE
[29/04/2024, 9:20 AM] [SettingsContainer] Roles have been modified from outside. Loading new store.
[29/04/2024, 9:21 AM] [SettingsContainer] Roles have been modified from outside. Loading new store.
[29/04/2024, 9:30 AM] [SettingsContainer] Roles have been modified from outside. Loading new store.
IAmVigneswaran commented 2 months ago

Further debugging,

Console-WE
IAmVigneswaran commented 2 months ago

The issue was caused by entitlements.plist https://github.com/TheAcharya/MarkerData/commit/085e68d30c26e7ba07cd8bced290a26f131e9216