TheAcharya / MarkerData

The avant-garde Marker extraction application crafted for Final Cut Pro
https://markerdata.theacharya.co
MIT License
22 stars 1 forks source link

Prevent users from typing `Marker ID` into the Rename Key Column #92

Closed IAmVigneswaran closed 1 month ago

IAmVigneswaran commented 2 months ago

@milanvarady Would it be possible for a way to prevent users from typing Marker ID into the Rename Key Column for both Notion and Airtable Panel.

Rename Key Column
warning-for-rename

We can have a warning message beside the Cancel button.

The message can be 'Marker ID' is the default key column and cannot be used in the 'Rename Key Column' field. Please enter a different key column name if you wish to use this field.

milanvarady commented 2 months ago

I added it to the validation process. It shows a popup alert if the rename key column is wrong.

IAmVigneswaran commented 2 months ago

@milanvarady After typing Marker ID into the rename key column and pressing save, the app turns to Inactive.

IAmVigneswaran commented 2 months ago

I also notice that at times, when entering Marker ID. The error message does not appear.

milanvarady commented 1 month ago

It works as intended every time for me. Can you check in Console.app if you see any related errors?

https://github.com/TheAcharya/MarkerData/assets/61704770/bf6f2b44-3dbd-431e-9069-e2429b441252

IAmVigneswaran commented 1 month ago

@milanvarady You can see that, after clicking Save, the app goes to inactive state.

https://github.com/TheAcharya/MarkerData/assets/118706051/3abd72fa-49b0-4bef-afdb-9005fb833813

IAmVigneswaran commented 1 month ago

@milanvarady Try this.

  1. Create a new Notion / Airtable Database Profile
  2. Enter any value such as Shot ID into Rename Key Column.
  3. Press Save.
  4. Now, Press Edit and change Shot ID to Marker ID.
  5. Press OK
  6. I believe you would see the bug now.
milanvarady commented 1 month ago

You can see that, after clicking Save, the app goes to inactive state.

@IAmVigneswaran I caught the bug. It was closing the popup when it shouldn't have. Should be fixed now.