search

TheAcharya / MarkersExtractor

Extract Markers from Final Cut Pro FCPXML
MIT License
36 stars 2 forks source link

Image Extraction Fails When Project's Timecode starts from 01:00:00:00 #60

Closed IAmVigneswaran closed 10 months ago

IAmVigneswaran commented 10 months ago

@orchetect Our CLI fails to extract the images when Final Cut Pro's Project Timecode starts at 01:00:00:00.

Project-Timecode 
2023-11-13 19:02:26 info: 5%
2023-11-13 19:02:26 info: 10%
2023-11-13 19:02:26 info: 15%
2023-11-13 19:02:26 info: 20%
2023-11-13 19:02:26 info: 24%
2023-11-13 19:02:26 info: 28%
ld/Info.fcpxml"...
2023-11-13 19:02:26 info: Project start timecode: 01:00:00:00 @ 24 fps.
2023-11-13 19:02:26 info: Found project media file: "/Users/XXX/Desktop/Marker_Data/App/Render/Test.mov".
2023-11-13 19:02:26 info: Generating metadata file(s) with PNG thumbnail images into "/Users/XXX/Desktop/Marker_Data/App/0.2.3/Output/Test 2023-11-13 07-02-26".
2023-11-13 19:02:26 info: Exporting marker icons...
2023-11-13 19:02:26 info: Generating PNG images for markers...
2023-11-13 19:02:26 info: Creating "done.json" done file at "/Users/XXX/Desktop/Marker_Data/App/0.2.3/Output/Test 2023-11-13 07-02-26".
2023-11-13 19:02:26 info: Done
orchetect commented 10 months ago

This gives literally no information. Do you have a fcpxml file to repro this?

IAmVigneswaran commented 10 months ago

This gives literally no information. Do you have a fcpxml file to repro this?

I have emailed you. Since it is a large file.

orchetect commented 10 months ago

Ah gotcha - I thought that was just a summary of recent issues.

orchetect commented 10 months ago

Again, like the other issue, I think this was just a byproduct of the old XML parser.

With the new DAWFileKit refactors, this parses fine.

fcp-marker-list

csv

I'll close this issue as resolved. The next major release will have the fix.

IAmVigneswaran commented 10 months ago

Awesome! Thank you.