search

TheAcharya / MarkersExtractor

Extract Markers from Final Cut Pro FCPXML
MIT License
36 stars 2 forks source link

Tweaking Audio Roles Assignment for Titles & Video Generators #91

Closed IAmVigneswaran closed 5 months ago

IAmVigneswaran commented 8 months ago

https://github.com/TheAcharya/MarkerData/issues/21#issuecomment-1916776555

After further tests, I realise that since, since we are assigning Dialogue.Dialogue-1 to the Title Clips, we can't able to extract Marker on Titles without selecting Dialogue.Dialogue-1 in our Roles Tab within Workflow Extension.

Titles-Issue-01

After selecting Title and Dialogue.Dialogue-1 I am able to extract just the Titles alone.

Titles-Issue-02

User would not know to select Dialogue.Dialogue-1 when selecting specific roles, since within FCP, Titles and Video Generators are not assigned with Audio Roles.

Titles-Issue-03

What is the best approach to solve this? Should we just keep the Audio Role & Subrole empty when there is no assign or not applicable?

orchetect commented 5 months ago

hmm. Yeah, in FCP it looks like Titles clips aren't even allowed to have an audio role selected, it just shows it blank and it's not selectable.

On reflection, this seems like it may be an oversight with the parsing. I'm not sure why it would be putting Dialog there. It would make sense to keep the audio role empty.

orchetect commented 5 months ago

I've made the necessary fix in DAWFileKit and will test MarkersExtractor to ensure correct behavior.

orchetect commented 5 months ago

Since MarkersExtractor replaces empty roles with "Not Assigned", that is what is now being output for Titles as its audio role. That should be fine, and seems consistent.

IAmVigneswaran commented 5 months ago

Since MarkersExtractor replaces empty roles with "Not Assigned", that is what is now being output for Titles as its audio role. That should be fine, and seems consistent.

Yes, on our output payloads, we can print Not Assigned for Titles.

IAmVigneswaran commented 5 months ago

Just tested this! Seems to be working.