TheAcharya / MarkersExtractor

Extract Markers from Final Cut Pro FCPXML
MIT License
36 stars 2 forks source link

Both CSV & TSV Profiles does not include images when extracting #94

Closed IAmVigneswaran closed 5 months ago

IAmVigneswaran commented 5 months ago

@orchetect I just realise this issue comes from MarkersExtractor.

For both CSV & TSV export profiles does not include images when extracting the timeline.

"$TOOL_PATH" "$FCPXML_PATH" "$OUTPUT_DIR" --export-format csv --image-format png --result-file-path "$RESULT_JSON" --log-level debug --log "$ERROR_LOG"
orchetect commented 5 months ago

That's not a bug, it's by design. CSV and TSV shouldn't be exporting images. I disabled it when fixing the MIDI file export bug.

IAmVigneswaran commented 5 months ago

That's not a bug, it's by design. CSV and TSV shouldn't be exporting images. I disabled it when fixing the MIDI file export bug.

Actually, there should be images for both CSV and TSV. That way, users can import images into their custom workflows, offline database. Not just Notion or Airtable.

orchetect commented 5 months ago

What if we don't want images and just want the csv/tsv? I don't think we should force image generation for those profiles.

IAmVigneswaran commented 5 months ago

What if we don't want images and just want the csv/tsv? I don't think we should force image generation for those profiles.

That is the reason why we have No Media option.

Image Generation should be on by default. It is the key and highlight feature of Marker Data. If users don't want it, they can enable, No Media option or use Workflow Extension.

orchetect commented 5 months ago

That might not be totally intuitive for new users. I wonder if there is a way to communicate more clearly that No Media means that thumbnail generation will be skipped.

IAmVigneswaran commented 5 months ago

That might not be totally intuitive for new users. I wonder if there is a way to communicate more clearly that No Media means that thumbnail generation will be skipped.

I can rename No Media to Skip Image Generation.

Let's enable Image Generation back for both CSV and TSV in 0.3.5.

IAmVigneswaran commented 5 months ago

Done. https://github.com/TheAcharya/MarkerData/commit/a5ee23dc7ed9b25f7099b071e465aca9f3582804

orchetect commented 5 months ago

Done. Will be in 0.3.5.