search

TheAcharya / MarkersExtractor

Extract Markers from Final Cut Pro FCPXML
MIT License
37 stars 2 forks source link

Resolve thread sanitizer issues #98

Open orchetect opened 6 months ago

orchetect commented 6 months ago

Reported in: 0.3.6

When Thread Sanitizer is enabled in Xcode, some warnings are posted to the console. This likely is a byproduct of the multi-threading that was introduced a little while ago (#49).

But in practice, the operation of the tool does not seem to be adversely affected (it works as expected). It's likely the warnings are being triggered by an over-abundance of caution from the TSAN but it would still be good to resolve them.

IAmVigneswaran commented 5 months ago

The warnings don't show up in GitHub build action? Or do we need to enable any special switches to show the warnings.

orchetect commented 5 months ago

When Thread Sanitizer is enabled in Xcode

IAmVigneswaran commented 5 months ago

Ahh noted!

Reading some articles related to Thread Sanitizer.

https://www.avanderlee.com/swift/thread-sanitizer-data-races/ https://undo.io/resources/gdb-watchpoint/using-threadsanitizer-to-debug-data-races https://medium.com/@lucianoalmeida1/i-little-bit-about-thread-sanitizer-56a887dc144

orchetect commented 5 months ago

This is just something I need to debug when I have time. Was just logging the issue for reference.