TheAfroOfDoom / omega-flowey-minecraft-remastered

MIT License
1 stars 1 forks source link

add linting rules for datapack/resourcepack #37

Open TheAfroOfDoom opened 6 months ago

TheAfroOfDoom commented 6 months ago

we get a little bit of linting in vscode with Datapack Helper Plus, but DHP is pretty buggy and we shouldn't rely on it to actually lint, I don't think.

instead we should probably write a script in-house to do stuff before we run the test server:

we'd want the linting script to ensure to run on specific files (.mcfunction, .json, etc.) and check that:

we'll probably want more rules than above but that's a decent start.


adding linting ensures our files have consistent styling (like SNBT whitespace)


~we'd also want to add this script to the datapack.yml/resourcepack.yml workflows so that we run the linting script before we run the test server~ done

TheAfroOfDoom commented 6 months ago

linting rule idea: ensure every instance of # TODO is in the correct format:

TheAfroOfDoom commented 6 months ago

infrastructure for this was added in a50e084 (#62)

should be pretty easy now to add rules for the things mentioned above

see 787cd85 (#62)

TheAfroOfDoom commented 5 months ago

https://github.com/TheAfroOfDoom/omega-flowey-minecraft-remastered/issues/37#issuecomment-1867324738

the TODO linting rule was done in e1b3d7a (#67)