TheAfroOfDoom / omega-flowey-minecraft-remastered

MIT License
1 stars 1 forks source link

parameterize `entity:utils/shake_screen`'s yaw/pitch ranges with macros #38

Open TheAfroOfDoom opened 6 months ago

TheAfroOfDoom commented 6 months ago

currently its values are hard-coded:

TODO of this issue is to make this function take in macros (probably like yaw_min, yaw_max).

would also need to convert places that call this already to input parameter macros with the currently hard coded values (above)

https://github.com/TheAfroOfDoom/omega-flowey-minecraft-remastered/blob/afb1cc943424e4145c365b8503f9b30655effa6f/datapacks/omega-flowey/data/entity/functions/hostile/omega-flowey/attack/dentata-snakes/bullet/loop/bounce.mcfunction#L33

TheAfroOfDoom commented 4 months ago

parameterization work was done in #85 that this ticket can likely follow the pattern of. id like to call out in particular that we can pass in string parameters as macros to call specific functions with:

https://github.com/TheAfroOfDoom/omega-flowey-minecraft-remastered/blob/f42b000a556c364dabcf6462918e18681ea867cc/datapacks/omega-flowey/data/entity/functions/hostile/omega-flowey/attack/dentata-snakes/bullet/loop/maybe_bounce.mcfunction#L10

https://github.com/TheAfroOfDoom/omega-flowey-minecraft-remastered/blob/f42b000a556c364dabcf6462918e18681ea867cc/datapacks/omega-flowey/data/entity/functions/utils/bounce.mcfunction#L35-L36