Feat: add cycle sort - Githubissues

TheAlgorithms / Algorithms-Explanation

Popular algorithms explained in simple language with examples and links to their implementation in various programming languages and other required resources.

MIT License

2.97k stars 738 forks source link

Feat: add cycle sort #212

Closed BSzmolke closed 1 year ago

BSzmolke commented 1 year ago

Description

Add short description of cycle sort algorithm

Checklist

[x] A description of the changes in this PR is mentioned above.
[x] All the new and existing checks pass.
[x] No plagiarized, duplicated, or repetitive documentation that has been directly copied from another source.
[x] If it's a new explanation, it contains solid, understandable, and accessible information.
[x] I have read the whole contributing guidelines and agree to the Code of Conduct.

BSzmolke commented 1 year ago

Looks fine, minor formatting issues can be fixed later on. Aren't the implementation links redundant with the The Algorithms page?

@appgurueu I thought it's expected as per line:

https://github.com/TheAlgorithms/Algorithms-Explanation/blob/d01394019bacefb5bb6da4e37098813c5fbb597e/CONTRIBUTING.md?plain=1#L37

But I'm happy to remove if you think it would be better without it

appgurueu commented 1 year ago

Looks fine, minor formatting issues can be fixed later on. Aren't the implementation links redundant with the The Algorithms page?

@appgurueu I thought it's expected as per line:

https://github.com/TheAlgorithms/Algorithms-Explanation/blob/d01394019bacefb5bb6da4e37098813c5fbb597e/CONTRIBUTING.md?plain=1#L37

But I'm happy to remove if you think it would be better without it

I think you should remove the direct links to implementations, not the link to The Algorithms.

BSzmolke commented 1 year ago

Redundant links removed