Adding Boruvka algorithm + tests for Minimum Spanning Trees - Githubissues

TheAlgorithms / C-Plus-Plus

Collection of various algorithms in mathematics, machine learning, computer science and physics implemented in C++ for educational purposes.

https://thealgorithms.github.io/C-Plus-Plus

MIT License

29.7k stars 7.05k forks source link

Adding Boruvka algorithm + tests for Minimum Spanning Trees #2676

Closed FranciscoThiesen closed 2 months ago

FranciscoThiesen commented 6 months ago

Description of Change

Checklist

[x] Added description of change
[x] Added file name matches File name guidelines
[x] Added tests and example, test must pass
[x] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
[x] Relevant documentation/comments is changed or added
[x] PR title follows semantic commit guidelines
[x] Search previous suggestions before making a new one, as yours may be a duplicate.
[x] I acknowledge that all my contributions will be made under the project's license.

Notes:

FranciscoThiesen commented 6 months ago

@Panquesito7 @realstealthninja reviews appreciated, thank you!

FranciscoThiesen commented 5 months ago

@realstealthninja I've addressed your suggestions. Also changed from int -> uint32_t in the union find, where negative values also don't make sense.

Let me know if there are any other issues.

FranciscoThiesen commented 5 months ago

@realstealthninja iterated on the last round of reviews!

FranciscoThiesen commented 5 months ago

@realstealthninja can you approve the workflows?

Thank you, Francisco

FranciscoThiesen commented 5 months ago

@realstealthninja @Panquesito7 can you please approve the required workflows? I've addressed all the comments/suggested changes.

Thank you, Francisco

FranciscoThiesen commented 5 months ago

@realstealthninja @Panquesito7

FranciscoThiesen commented 4 months ago

@realstealthninja @Panquesito7 any updates? I'd like to merge this if possible

FranciscoThiesen commented 4 months ago

@realstealthninja @Panquesito7

FranciscoThiesen commented 3 months ago

@realstealthninja @Panquesito7 can you kindly take a look? I have addressed all the changes requested and this is ready to merge. I can't initiate the checks and I am not currently a contributor.

github-actions[bot] commented 2 months ago

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 2 months ago

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!