TheAlgorithms / C-Sharp

All algorithms implemented in C#.
GNU General Public License v3.0
7.12k stars 1.52k forks source link

Generic implementation of factorial function #390

Closed craftycoder07 closed 1 year ago

craftycoder07 commented 1 year ago
siriak commented 1 year ago

Please also update dotnet version in https://github.com/TheAlgorithms/C-Sharp/blob/master/.github/workflows/ci.yml

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (52bf864) 95.75% compared to head (8cd5fef) 95.76%.

:exclamation: Current head 8cd5fef differs from pull request most recent head 6c69094. Consider uploading reports for the commit 6c69094 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #390 +/- ## ======================================= Coverage 95.75% 95.76% ======================================= Files 218 218 Lines 8887 8902 +15 ======================================= + Hits 8510 8525 +15 Misses 377 377 ``` | [Impacted Files](https://codecov.io/gh/TheAlgorithms/C-Sharp/pull/390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [Algorithms/Numeric/Factorial.cs](https://codecov.io/gh/TheAlgorithms/C-Sharp/pull/390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-QWxnb3JpdGhtcy9OdW1lcmljL0ZhY3RvcmlhbC5jcw==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

siriak commented 1 year ago

BinomialCoefficient was updated to work with BigInteger, so you might want to pull those changes, and it should be easier to implement this now

craftycoder07 commented 1 year ago

I accidentally closed this pull request. Maclaurin.cs is using Factorial function as well. Do you want me to make temp changes in it?

craftycoder07 commented 1 year ago

I am closing this pull request as solution is implemented in other pull request and is merged.