Currently in pre-commitnpm run style is used. This formats the files but the changes are not added to the commit (and the command is successful). I would suggest to use npm run check-style, which fill fail, if there are some files requiring reformatting. It fits to the logic behind npm run test.
[x] This pull request is all my own work -- I have not plagiarized.
[x] I know that pull requests will not be merged if they fail the automated tests.
[x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
[x] All new JavaScript files are placed inside an existing directory.
[x] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
[x] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
[x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
Describe your change:
Currently in
pre-commit
npm run style
is used. This formats the files but the changes are not added to the commit (and the command is successful). I would suggest to usenpm run check-style
, which fill fail, if there are some files requiring reformatting. It fits to the logic behindnpm run test
.Checklist:
UserProfile.js
is allowed butuserprofile.js
,Userprofile.js
,user-Profile.js
,userProfile.js
are notFixes: #{$ISSUE_NO}
.