refactor: use `isLeapYear`

vil02 commented 4 months ago

know more

Describe your change:

This PR:

applies the isLeapYear,
reorganizes the tests of GetMonthDays - note the change of the year in one of the test cases (I do not want to create an illusion that this function should be uses for years before 1582).

Checklist:

[x] I have read CONTRIBUTING.md.
[x] This pull request is all my own work -- I have not plagiarized.
[x] I know that pull requests will not be merged if they fail the automated tests.
[x] ~This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.~
[x] All new JavaScript files are placed inside an existing directory.
[x] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
[x] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
[x] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.94%. Comparing base (d8cfdcd) to head (66ab291).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1638 +/- ## ======================================= Coverage 83.93% 83.94% ======================================= Files 377 377 Lines 19733 19727 -6 Branches 2921 2918 -3 ======================================= - Hits 16563 16559 -4 + Misses 3170 3168 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vil02 commented 4 months ago

@appgurueu or @raklaptudirm could you please re-run the UploadCoverageReport (if needed). It failed due to: The server encountered a temporary error and could not complete your request.

appgurueu commented 4 months ago

(Just amended your last commit and force pushed to trigger a rerun of CI)

vil02 commented 4 months ago

(Just amended your last commit and force pushed to trigger a rerun of CI)

I could do the same, but I did not want to lose your approval. Thanks!

appgurueu commented 4 months ago

I could do the same, but I did not want to lose your approval. Thanks!

Heh, right. Sometimes our strict repo config frustrates me a bit.

TheAlgorithms / JavaScript