search

TheAlgorithms / PHP

All Algorithms implemented in PHP
MIT License
2.14k stars 467 forks source link

Create BaseX.php #140

Closed Sevada797 closed 11 months ago

Sevada797 commented 1 year ago

This function let's you calculate base X of any number <11

Sevada797 commented 1 year ago

Hi @darwinz thanks for checking my commit, I have read the file CONTRIBUTING.md, I think everything is OK, if possible please tell me what exact changes should I make.

darwinz commented 1 year ago

Please follow modern PHP style guide rules. We generally stick to the guidelines in the PSR-12 style guide. Code should be in a class or function that defines the algorithm. You also need to add unit tests. Format your code so that it's readable and maintainable using the PSR-12 style guide. Thanks!

Sevada797 commented 12 months ago

Please follow modern PHP style guide rules. We generally stick to the guidelines in the PSR-12 style guide. Code should be in a class or function that defines the algorithm. You also need to add unit tests. Format your code so that it's readable and maintainable using the PSR-12 style guide. Thanks!

I've done it, can you please check it, sorry for the long delay.

Sevada797 commented 11 months ago

Hi @darwinz, can you see if everything is okay now please?