search

TheAlgorithms / Ruby

All algorithms implemented in Ruby
MIT License
1.15k stars 289 forks source link

PR for find max feature #131

Closed msaf9 closed 3 years ago

msaf9 commented 3 years ago

@jsca-kwok I have implemented all your suggestions, can you please review and approve my PR?

msaf9 commented 3 years ago

@jsca-kwok Thanks for your kind words. I have implemented your suggestions. Can you please review and let me know for any other aspect?

jsca-kwok commented 3 years ago

@jsca-kwok Thanks for your kind words. I have implemented your suggestions. Can you please review and let me know for any other aspect?

Yep! I've approved :) just don't forget to update the directory with your solution

msaf9 commented 3 years ago

Updated DIRECTORY.

jsca-kwok commented 3 years ago

Updated DIRECTORY.

Sorry I should've mentioned updating it in alphabetical order :sweat_smile:

msaf9 commented 3 years ago

No worries, I have changed it, according to the alphabetical order.