search

TheAlgorithms / Ruby

All algorithms implemented in Ruby
MIT License
1.15k stars 289 forks source link

chore: use workflow from the `scripts` repository #209

Closed Panquesito7 closed 1 year ago

Panquesito7 commented 1 year ago

Things added/changed:

vzvu3k6k commented 1 year ago

@Panquesito7 It seems I missed something during the review...

The action failed after the merge (log). So this PR has been temporarily reverted by #211.

I would appreciate it if you could submit a pull request with the bug fixed. I will investigate when I have time as well.

(By the way, I checked the TheAlgorithms/C-Plus-Plus repository again, and it appears that this action is not actually executed, because the branch name of the action on.push.branches and the default branch are different.)

Panquesito7 commented 1 year ago

Thanks for spotting that out! Weird that happened 👀 I believe the issue should be made in the scripts repository. Would you like to report it or should I do it myself? Thanks. 🙂

vzvu3k6k commented 1 year ago

@Panquesito7 Thanks for the confirmation! I have reported it in https://github.com/TheAlgorithms/scripts/issues/27.

For the TheAlgorithms/C-Plus-Plus, I'm not sure whether to report the issue in an existing issue or create a new one. I'll leave the decision up to you.

Anyway I think this workflow would be very useful if it works. Thank you for trying to develop it :+1: