Closed salmanmkc closed 6 months ago
Attention: Patch coverage is 86.95652%
with 6 lines
in your changes are missing coverage. Please review.
Project coverage is 94.77%. Comparing base (
20c92d7
) to head (4be9f49
).
Files | Patch % | Lines |
---|---|---|
src/data_structures/queue.rs | 80.00% | 3 Missing :warning: |
src/data_structures/range_minimum_query.rs | 40.00% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
in draft mode, just doing this for fun and will get back but got a bunch of things I need to run to first
Pull Request Template
Description
Just added some extra tests and used typiing for some errors. Might do some more soon.
Type of change
Please delete options that are not relevant.
Checklist:
cargo clippy --all -- -D warnings
just before my last commit and fixed any issue that was found.cargo fmt
just before my last commit.cargo test
just before my last commit and all tests passed.mod.rs
file within its own folder, and in any parent folder(s).DIRECTORY.md
with the correct link.COUNTRIBUTING.md
and my code follows its guidelines.Please make sure that if there is a test that takes too long to run ( > 300ms), you
#[ignore]
that or try to optimize your code or make the test easier to run. We have this rule because we have hundreds of tests to run; If each one of them took 300ms, we would have to wait for a long time.