Closed BenjiAndre closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.00%. Comparing base (
0cc792c
) to head (5ec1c09
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Pull Request Template
Description
This pull request fixes issue #714.
1. Fix
partition
Functionlist.swap(right, store_index)
statement was placed inside the loop, causing incorrect behavior during the partitioning step.list.swap(right, store_index)
statement outside the loop to correctly move the pivot to its final place after partitioning.2. Adjust Pivot Selection in
quick_select
Functionleft + (right - left) / 2
to ensure a valid pivot index within the given range.3. Correct Test Case
Detailed Changes
Partition Function:
Quick Select Function:
Test Case Correction:
These changes ensure the Quickselect algorithm functions correctly and the test cases produce the expected results.
Type of change
Please delete options that are not relevant.
Checklist:
cargo clippy --all -- -D warnings
just before my last commit and fixed any issue that was found.cargo fmt
just before my last commit.cargo test
just before my last commit and all tests passed.COUNTRIBUTING.md
and my code follows its guidelines.