TheAlgorithms / Rust

All Algorithms implemented in Rust
MIT License
21.51k stars 2.1k forks source link

Refactor NQueens implementation #732

Closed TruongNhanNguyen closed 1 week ago

TruongNhanNguyen commented 1 month ago

Changes

Checklist:

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.04%. Comparing base (c502484) to head (da01917).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #732 +/- ## ========================================== - Coverage 95.04% 95.04% -0.01% ========================================== Files 305 305 Lines 22677 22674 -3 ========================================== - Hits 21553 21550 -3 Misses 1124 1124 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TruongNhanNguyen commented 1 week ago

Can you have a look on this PR, @vil02?

TruongNhanNguyen commented 1 week ago

Can you review this PR, @vil02?

vil02 commented 1 week ago
* Rewrite `NQueensSolver` in OOP style

By the way: there is not much of OOP in this implementation (which is nothing bad). It is class based at most.

TruongNhanNguyen commented 1 week ago
* Rewrite `NQueensSolver` in OOP style

By the way: there is not much of OOP in this implementation (which is nothing bad). It is class based at most.

Thanks for pointing this out. I overused the OOP word in this context.