Closed TruongNhanNguyen closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.04%. Comparing base (
c502484
) to head (da01917
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can you have a look on this PR, @vil02?
Can you review this PR, @vil02?
* Rewrite `NQueensSolver` in OOP style
By the way: there is not much of OOP in this implementation (which is nothing bad). It is class based at most.
* Rewrite `NQueensSolver` in OOP style
By the way: there is not much of OOP in this implementation (which is nothing bad). It is class based at most.
Thanks for pointing this out. I overused the OOP word in this context.
Changes
NQueensSolver
in OOP stylen_queens_solver
method to hide internal state ofNQueensSolver
objectChecklist:
cargo clippy --all -- -D warnings
just before my last commit and fixed any issue that was found.cargo fmt
just before my last commit.cargo test
just before my last commit and all tests passed.mod.rs
file within its own folder, and in any parent folder(s).DIRECTORY.md
with the correct link.COUNTRIBUTING.md
and my code follows its guidelines.