Closed jkauerl closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.95%. Comparing base (
1d9c510
) to head (30f8b05
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Let's first focus on #734.
Pull Request Template
Description
PR including the implementation for the Marginal Ranking Loss Function of this issue #559 . It creates a new file called
marginal_ranking.rs
with the function calledmrg_ranking_loss
. This implementation is inspired on the documentation of PyTorch of Marginal Ranking.Type of change
Checklist:
cargo clippy --all -- -D warnings
just before my last commit and fixed any issue that was found.cargo fmt
just before my last commit.cargo test
just before my last commit and all tests passed.mod.rs
file within its own folder, and in any parent folder(s).DIRECTORY.md
with the correct link.COUNTRIBUTING.md
and my code follows its guidelines.PD: Im new to Rust and Open Source so I would love a clarification regarding the items I did not checked. Also let me know if I should squash the commits.