Closed Cheshulko closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.01%. Comparing base (
864ef42
) to head (e0483a9
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Pull Request Template
Description
Fixed the implementation of
gcd_extended
andmod_inverse
. Reference: Thomas H. Cormen, Charles E. Leiserson, Ronald L. Rivest, Clifford Stein - Introduction to algorithms, 3rd edition. Page 937.The extended form of Euclid’s algorithm
Type of change
Current implementation is wrong. Examples:
The test
passed because
mod_inverse(123, 67)
is0
in current implementation. Correct value is 6 and it overflowsi64
6.pow(45) = 1,03945637534×10³⁵
.Checklist:
cargo clippy --all -- -D warnings
just before my last commit and fixed any issue that was found.cargo fmt
just before my last commit.cargo test
just before my last commit and all tests passed.COUNTRIBUTING.md
and my code follows its guidelines.