Closed dev-priyanshu15 closed 1 month ago
add hacktoberfest label please
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.32%. Comparing base (
0dbaff5
) to head (0e9e30f
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
please add hacktoberfest label
Could you please read the CONTRIBUTING guidelines before submitting the PR? By the way, don't try to spam PR just for hacktoberfest.
The quality of this submission is so low, that the effort needed to review it is much higher than implementing this feature from the scratch.
suggest some changes
In your mod.rs file, make sure to declare the additional modules:
code // mod.rs pub mod bearing; pub mod haversine; pub mod vincenty; // Add the new module for Vincenty formula
This setup provides a good starting point for your navigation algorithms in Rust.
Pull Request Template
Description
Please include a summary of the change and which issue (if any) is fixed. A brief description of the algorithm and your implementation method can be helpful too. If the implemented method/algorithm is not so well-known, it would be helpful to add a link to an article explaining it with more details.
Type of change
Please delete options that are not relevant.
Checklist:
cargo clippy --all -- -D warnings
just before my last commit and fixed any issue that was found.cargo fmt
just before my last commit.cargo test
just before my last commit and all tests passed.mod.rs
file within its own folder, and in any parent folder(s).DIRECTORY.md
with the correct link.COUNTRIBUTING.md
and my code follows its guidelines.Please make sure that if there is a test that takes too long to run ( > 300ms), you
#[ignore]
that or try to optimize your code or make the test easier to run. We have this rule because we have hundreds of tests to run; If each one of them took 300ms, we would have to wait for a long time.