Closed dlesnoff closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated |
---|---|---|---|---|
website | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Mar 17, 2023 at 3:39PM (UTC) |
caniuse-lite must be updated. Stars next to language repositories are equal to 0 (error: API limit exceeded). Nim logo is incorrect (it is a little crown).
Thanks for the PR.
Devicon (what we use for the icons) already seems to have the nim icon, but they haven't released a new version in a year. I've switched the url used for the icons to use the development branch of devicon, that way we get the nim icon.
The issue with the 0 stars should not happen on the actual website, we use a api key there. And I will fix the other issues (caniuse,linting errors) outside of this PR.
Nim now appears on the website, but the logo still does not appear correctly. It is still written Nim in plain text instead of showing the crown.
Hm, works for me:
Ah its only a issue in the dark mode because there is no plain
nim devicon, you still have to use the original
one. I've pushed the fix.
I got it. I am in dark mode, and it does not have the dark mode version of the logo. Thanks.
Fix https://github.com/TheAlgorithms/Nim/issues/6
What change does this pull request introduce? Add Nim to the website. https://www.nim-lang.org/
Screenshots
Checklist
main
.main
branch.I am not familiar with yarn. I am waiting for fetch-algorithms.ts ending.
yarn lint
. There were 3 errors already present in preceding PRs. I do not know how to fix them and they are unrelated to my files.yarn build
to check everything still builds successfully.