TheAlienDoctor / minecraft-resource-pack-converter

Converts Minecraft resource packs between versions (Bedrock and Java)
BSD 3-Clause "New" or "Revised" License
49 stars 2 forks source link

Don't Clear the Output Directory When Generating the Pack #22

Open Kas-tle opened 6 months ago

Kas-tle commented 6 months ago

While I understand what you want to write to a clean directory, I still feel the current behavior does more harm than good. While it does warn the user that the directory will be cleared when starting conversion, it's fairly easy for someone, especially a non-technical user, to skip right past this.

Personally I've seen someone we recommended this converter to on an unrelated project do this and clear out their desktop. I feel a better solution would be to abort the conversion if the output directory is not clear, or simply write to the directory even if it's not empty. Better to end up with a cluttered desktop than an empty one.

TheAlienDoctor commented 2 months ago

Hi, apologies for the late reply.

The main reason for this is so that nothing gets overwritten or accidentally added to the final ZIP output when it's not supposed to. I think for the next update I will add a yes/no box or setting so that this can be disabled if people want.