TheAngryByrd / IcedTasks

F# Cold Tasks and Cancellable Tasks
https://www.jimmybyrd.me/IcedTasks/
MIT License
120 stars 5 forks source link

IAsyncEnumerable support #37

Closed TheAngryByrd closed 8 months ago

TheAngryByrd commented 8 months ago

Proposed Changes

Adds support for IAsyncEnumerable. Testing against TaskSeq

Types of changes

What types of changes does your code introduce to IcedTasks? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

TheAngryByrd commented 8 months ago

cc @abelbraaksma

abelbraaksma commented 4 months ago

Hey @TheAngryByrd I missed this. Do you still need me looking into this?

abelbraaksma commented 4 months ago

PS: TaskSeq is now at 0.4.0: https://www.nuget.org/packages/FSharp.Control.TaskSeq/0.4.0

TheAngryByrd commented 4 months ago

Nothing for you to look at. this was more just to make you aware of how I implemented it so you could add it to taskseq for task ce overloads if needed.

abelbraaksma commented 3 months ago

Yes, I actually have for .. in .. do support for async enumerables in task and async, didn't we make that together at the time? Anyway, thanks!

TheAngryByrd commented 3 months ago

We did but it was kind of janky and didn’t have a dynamic implementation