TheAngryByrd / MiniScaffold

F# Template for creating and publishing libraries targeting .NET 6.0 `net6.0` or console apps .NET 6.0 `net6.0`.
https://www.jimmybyrd.me/MiniScaffold/
MIT License
267 stars 31 forks source link

Resolves #187 #196

Closed ominestre closed 4 years ago

ominestre commented 4 years ago

Git stage all can accidentally include unintended changes into a release commit. This change explicitly instructs Git to only stage the CHANGELOG and the AssemblyInfo.

Resolves #187

Proposed Changes

In the build scripts Git stage all can accidentally include unintended changes into a release commit. This change explicitly instructs Git to only stage the CHANGELOG and the AssemblyInfo.

Types of changes

What types of changes does your code introduce to MiniScaffold? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

ominestre commented 4 years ago

@TheAngryByrd I didn't get to run a good test on this because of the Nuget publish step. If you have an idea of how to side-step that I can test this out or you're welcome to take a shot.

TheAngryByrd commented 4 years ago

Thanks a ton! I'll take a look at adding a test. Might not be worth it given integration points.