TheAngryByrd / MiniScaffold

F# Template for creating and publishing libraries targeting .NET 6.0 `net6.0` or console apps .NET 6.0 `net6.0`.
https://www.jimmybyrd.me/MiniScaffold/
MIT License
267 stars 31 forks source link

Update Fantomas and format using dotnet tool. #247

Closed nojaf closed 2 years ago

nojaf commented 2 years ago

Proposed Changes

Hi @TheAngryByrd, sorry for now opening an issue first. I'd like to bump the Fantomas version here, the current version 3.2 is quite old. And nowadays it is recommended to format outside of the FAKE process using the local .NET tool.

Types of changes

What types of changes does your code introduce to MiniScaffold? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

This PR isn't totally finished as I'm not sure if you are onboard with all the changes. I'll ask some specific questions in the code. Let me know what you think.

TheAngryByrd commented 2 years ago

Thank you! On mobile right now but I get a review in soon

nojaf commented 2 years ago

Hey @TheAngryByrd, thanks for the positive feedback! I've updated the Library as well and applied all feedback. Should be good to go, let me know if anything still needs a tweak.