TheAngryByrd
commented
1 year ago Unclosed question on test coverage verification. It is not necessary to evaluate test coverage every time you run tests, and to speed up feedback, it is inconvenient to write the cmd /c "set DISABLE_COVERAGE=1& build DotnetTest" command on Windows, for example. I propose to change the logic and replacing the environment variable with ENABLE_COVERAGE. And local testing with test coverage is convenient to do with a new ShowCoverageReport target. What do you think?
This is kind of tough call, some people use the coverage in their IDE to see things being covered, but coverage does slow down tests considerably. I'm leaning toward your suggestion though but I wouldn't be surprised if I get another issue down the road as to default have coverage on.
nikoyak
Proposed Changes
This PR:
Types of changes
What types of changes does your code introduce to MiniScaffold?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Unclosed question on test coverage verification. It is not necessary to evaluate test coverage every time you run tests, and to speed up feedback, it is inconvenient to write the
cmd /c "set DISABLE_COVERAGE=1& build DotnetTest"command on Windows, for example. I propose to change the logic and replacing the environment variable with ENABLE_COVERAGE. And local testing with test coverage is convenient to do with a new ShowCoverageReport target. What do you think?