search

TheAngryByrd / MiniScaffold

F# Template for creating and publishing libraries targeting .NET 6.0 `net6.0` or console apps .NET 6.0 `net6.0`.
https://www.jimmybyrd.me/MiniScaffold/
MIT License
267 stars 31 forks source link

Incorrect release guide on github pages #284

Closed PolinaSavelyeva closed 9 months ago

PolinaSavelyeva commented 9 months ago

Describe the bug The steps to add NUGET_TOKEN from https://www.jimmybyrd.me/MiniScaffold/Tutorials/Getting_Started_With_Libraries.html#Add-your-NUGET_TOKEN-to-your-environment are incorrect.

Expected behavior "Create an Environment on your repository named nuget." should be "Add your NuGet API key as repository secret NUGET_TOKEN to Actions secrets", as it mentioned in the project's README.

TheAngryByrd commented 9 months ago

It’s the other way around. The readme is incorrect. Would you like to send a PR to fix this?

PolinaSavelyeva commented 9 months ago

I've just checked the latest library template and still got error message while following steps described on pages. 

Could not push package /home/runner/work/Test/Test/dist/MyCoolNewLib.1.0.0.nupkg due to missing credentials 
for the url https://www.nuget.org/api/v2/package. Please specify a NuGet API key via the command line, the 
environment variable "nugetkey", or by using 'paket config add-token'.

Using Repository secrets instead of Environment secrets fixes the issue. If I understood correctly, i would like to send a PR.

TheAngryByrd commented 9 months ago

Oh you're right the template is missing the environment like in IcedTasks which should be set.