TheArcadiaGroup / gosuto-wallet-desktop-svelte

Gosuto Desktop App, private repo for development, eventually publishes to "GosutoWallet" public repo.
Other
1 stars 0 forks source link

Stake landing page #36

Closed tomashobzaids closed 2 years ago

tomashobzaids commented 2 years ago

Summary of this pull request:

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ids-company/gosuto-wallet-desktop/H5WSdPsDFCanC7ftt9PCAw7rYoev
✅ Preview: Failed

[Deployment for 1488ccd failed]

tomashobzaids commented 2 years ago

I will do move the tailwind classes to style tags and I also forgot to remove a testing element.

vercel[bot] commented 2 years ago

@tomashobzaids is attempting to deploy a commit to the IDS-COMPANY Team on Vercel.

To accomplish this, @tomashobzaids needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

Scientist-Ansh commented 2 years ago

@tomashobzaids is the StakeCard.svelte and StakesFromWallet.svelte components inside lib/components/StakesFromWallet supposed to be used only inside profile routes? or is it meant to reusable and will used at other pages as well?

tomashobzaids commented 2 years ago

@Scientist-Ansh As far as I'm aware, those are single use components.

Scientist-Ansh commented 2 years ago

@Scientist-Ansh As far as I'm aware, those are single use components. @tomashobzaids yeah if that's the case then I think you should create a directory inside the lib with the name Profile and these components should go in there. We put reusable components inside the lib/components. If components are one time use and specific for a route, then we create a folder inside lib with the same name as the route(PascalCase) and put them there.

gicharujohn commented 2 years ago

@tomashobzaids Hi, could you resolve this conflict and then we can check this

tomashobzaids commented 2 years ago

@gicharujohn conflicts resolved :)