TheAssassin / AppImageLauncher

Helper application for Linux distributions serving as a kind of "entry point" for running and integrating AppImages
https://assassinate-you.net/tags/appimagelauncher/
MIT License
5.57k stars 264 forks source link

Lunar Client AppImage not in the start menu #370

Open he3als opened 3 years ago

he3als commented 3 years ago

Describe the bug When I integrate and run the Lunar Client appimage on Ubuntu it doesn't go into the start menu. However, it does actually show up in the applications folder that AppImage launcher created.

Expected behaviour When I launched the Lunar Client and pressed integrate and run it should go into the menu.

To Reproduce Steps to reproduce the behaviour:

  1. Download the Lunar Client appimage from lunarclient.com
  2. Open it and integrate and run
  3. Look in your start menu, it will not be there/intergrated

Screenshots I do not currently have any screenshots. However, if you look in the comments, there are some screenshots.

System, software and AppImage information Distribution: Ubuntu Budgie | Desktop Environment: Budgie

AppImageLauncher version installed: Latest Version (I installed it with the instructions from the wiki)

Graphics card: Nvidia GTX 970 CPU: Intel i7 (I am on my phone right now, I do not know the exact CPU but I will provide if needed) RAM: 16GB DDR3 File System: ext4

List of AppImages you tried:

leleobhz commented 3 years ago

Hello,

I have same behavior of this bug:

leonardo@manauara:~$ LANG=C file  ~/.local/share/applications/appimagekit_ebf311bc8aa8927024f4377b1b56e849-all-in-one.desktop
/home/leonardo/.local/share/applications/appimagekit_ebf311bc8aa8927024f4377b1b56e849-all-in-one.desktop: ASCII text
leonardo@manauara:~$ LANG=C gtk-launch  ~/.local/share/applications/appimagekit_ebf311bc8aa8927024f4377b1b56e849-all-in-one.desktop
gtk-launch: no such application /home/leonardo/.local/share/applications/appimagekit_ebf311bc8aa8927024f4377b1b56e849-all-in-one.desktop
leonardo@manauara:~$ cat /home/leonardo/.local/share/applications/appimagekit_ebf311bc8aa8927024f4377b1b56e849-all-in-one.desktop
[Desktop Entry]
Name=All-in-One Messenger
Exec=/home/leonardo/Applications/All-in-One Messenger-2.0.0_5f13c6295f940f255a3c515b9e276844.AppImage
Terminal=false
Type=Application
Icon=appimagekit_ebf311bc8aa8927024f4377b1b56e849_all-in-one
StartupWMClass=All-in-One Messenger
X-AppImage-Version=2.0.0
Comment=One app for all your communication services! Use messengers like WhatsApp, Telegram, Messenger, Skype and many more in one app!
MimeType=x-scheme-handler/all-in-one;x-scheme-handler/mailto;
Categories=Network;InstantMessaging;
TryExec=/home/leonardo/Applications/All-in-One Messenger-2.0.0_5f13c6295f940f255a3c515b9e276844.AppImage
X-AppImage-Old-Icon=all-in-one
X-AppImage-Identifier=ebf311bc8aa8927024f4377b1b56e849
Actions=Remove;
X-AppImageLauncher-Version=2.2.0 (git commit 0f91801), built on 2020-10-29 08:08:13 UTC

[Desktop Action Remove]
Name=Remove AppImage from system
Icon=AppImageLauncher
Exec=/usr/lib/x86_64-linux-gnu/appimagelauncher/remove "/home/leonardo/Applications/All-in-One Messenger-2.0.0_5f13c6295f940f255a3c515b9e276844.AppImage"
leonardo@manauara:~$ 

Alt+F2, r does not load the .desktop and app is unable to run. Also, the first run after instalation leads to a broken image on dock icon.

themagicalcats commented 3 years ago

I have the same bug with the Lunar Client Appimage.

I would first get the appimage from https://www.lunarclient.com/download/ Then after that I would run it and as usual the AppImage Launcher will recognize it then I click integrate however in my XFCE Menu it doesn't show it and it's the same for some other menus. Screenshot_2020-12-15_16-24-10

TheAssassin commented 3 years ago

None of you has provided all the details requested by the issue template. There's a reason it's this detailed. I cannot spend time in every issue asking the same data. Please provide the minimum required information. Only then I can try to reproduce your issues.

Edit: The AppImage itself seems fine. I quickly ran in appimagelint on it, and it doesn't look like it should be causing issues.

he3als commented 3 years ago

Hello, sorry for not adding enough detail. I have now properly followed the template and gave as much details as I currently can. I am a newbie Linux user.

leleobhz commented 3 years ago

None of you has provided all the details requested by the issue template. There's a reason it's this detailed. I cannot spend time in every issue asking the same data. Please provide the minimum required information. Only then I can try to reproduce your issues.

Edit: The AppImage itself seems fine. I quickly ran in appimagelint on it, and it doesn't look like it should be causing issues.

I don't know if I agree with "not my issue" but I changed from Ubuntu to Fedora 33 and AppImageLauncher worked properly - including gnome-shell integration and icon, so I guess its some kind of misbehaviour with Ubuntu only.

About "every issue asking", isn't a good Idea to create a Umbrella ticket for integration issue and close issues claiming about this? Specially if its in fact a Ubuntu integration issue, as example.

leleobhz commented 3 years ago

About you template question, you also lack information about how to get the information you want. I provided the first information I could but I dont think you will be able to create a diagnostic with only distro data - as example.

Also, I followed entire journalctl log while trying to add integration and did not saw any log line about AppImageLauncher in it, so it maybe some other issue like dbus misbehaving or some other gnome internal issue. That said, how to get all information you need?

joserobjr commented 3 years ago

This also happened to me, but since I'm a developer I was able to troubleshoot the problem until I find the cause.

This problem happens when the file name contains spaces, after integration the file is moved to the Applications folder and renamed to have a suffix, but the spaces in the name are kept.

When the .desktop file is generated the Exec= will contains a command with space in it but without quotes, so it will be unable to be executed, the Ubuntu menu then hides the entry because it gets considered corrupted or outdated/removed.

There are two ways to solve it:

  1. Wrap the file name in quotes (and escape \ and quotes in the file name to avoid issues with weird or malicious file names)
  2. Normalize the filename removing spaces and special characters (but note that the path to the Application directory may also have the same issues as above in the parent folders, so I guess the first option is better)

For users:

As a workaround: Rename the file to remove any spaces or special chars manually before running

If you have already executed:

  1. Open ~/.local/share/applications
  2. Find the .desktop file for the application that didn't work
  3. Right click and open with a text editor
  4. Find the Exec line and fixes the command manually by adding quotes to the path to the file. Don't change the TryExec, the spaces there are fine.
  5. Then ALT + F2 and type restart to reload the menu (on Ubuntu, I don't know on other distributions)

Example:

# before change:
Exec=/home/joserobjr/Applications/Minecraft Bedrock Edition_be4af5f887b0c32ba52b11f4017643d6.AppImage -name mcpelauncher
TryExec=/home/joserobjr/Applications/Minecraft Bedrock Edition_be4af5f887b0c32ba52b11f4017643d6.AppImage

# after change:
Exec="/home/joserobjr/Applications/Minecraft Bedrock Edition_be4af5f887b0c32ba52b11f4017643d6.AppImage" -name mcpelauncher
TryExec=/home/joserobjr/Applications/Minecraft Bedrock Edition_be4af5f887b0c32ba52b11f4017643d6.AppImage
he3als commented 3 years ago

Hey, thanks for the reply. Possibly make another issue for this (if this is a bug with AppImageLauncher) so it can be fixed.

TheAssassin commented 3 years ago

If this is really a bug in the integration logic, please open an issue over at libappimage.