AppImageLauncher does not integrate Digikam 8.4.0 AppImage

rlfschmd commented 4 months ago

Pre-submit checks

[X] I checked for similar issues beforehand, but could not find any, not even closed ones. I could not add my bug report to any existing issue.
[X] I am going to take the time to to fill in all the required details. I know that the bug report will be dismissed otherwise.

Describe the bug

Exceuting the 'Integrate to system and run' command when first clicking the AppImage moves the AppImage to the desired location but shows the error 'Failed to register AppImage in system via libappimage' after. The AppImage won't show in the menu and no .desktop file is created. Until Digikam 8.3.0 it all worked fine. The Digikam developers sent me here, since they are sure it is an AIL issue.

Trying the integration via Terminal, I receive the following:

$ chmod a+x /home/xxxx/Applications/digiKam-8.4.0-Qt6-x86-64.appimage 
$ /home/rs/Applications/digiKam-8.4.0-Qt6-x86-64.appimage install

AppImageLauncher error: appimage_shall_not_be_integrated() failed (returned -1)
AppImageLauncher error: appimage_is_terminal_app() failed (returned -1)

(process:5399): GLib-CRITICAL **: 10:03:35.339: g_file_test: assertion 'filename != NULL' failed
(process:5399): GLib-CRITICAL **: 10:03:46.030: g_path_get_basename: assertion 'file_name != NULL' failed
** (process:5399): CRITICAL **: 10:03:46.030: Failed to find desktop file path

Expected behavior

Exceuting the 'Integrate to system and run' command when first clicking the AppImage usually moves the AppImage to the desired location and saves an appropriate .desktop file to ~/.local/share/applications/. The app is launchable from start menu then and behaves more or less the same as any other app.

Steps to reproduce the issue

Execute the 'Integrate to system and run' command when first clicking the AppImage.

Screenshots

No response

Distribution and desktop environment

Kubuntu 22.04 KDE Plasma Version: 5.27.11 KDE Frameworks Version: 5.104.0 Qt Version: 5.15.3

(Exactly the same issue happens on Mint 21.3)

Installed AppImageLauncher version

AppImageLauncher version 2.2.0 (git commit 0f91801), built on 2022-11-02 23:51:55 UTC

List of AppImages you tried

https://download.kde.org/stable/digikam/8.4.0/digiKam-8.4.0-Qt6-x86-64.appimage (not working) https://download.kde.org/stable/digikam/8.4.0/digiKam-8.4.0-Qt5-x86-64.appimage (not working)

Additional context

No response

biokomiker commented 4 months ago

I can confirrm the bug. Ubuntu 22.04, gnome, wayland.

> Jul 23 21:53:14 appimagelauncherd[5365]: Integrating: /home/xxxx/Applications/digiKam-8.4.0-Qt6-x86-64_97532ebe62ba5dabb5109d0c795a129c.appimage
> Jul 23 21:53:14 appimagelauncherd[5365]: WARNING: AppImage shall not be integrated, skipping
> Jul 23 21:53:14 appimagelauncherd[5365]: Cleaning up old desktop integration files
> Jul 23 21:53:14 appimagelauncherd[5365]: Updating desktop database and icon caches

Fourdogslong commented 3 months ago

I can confirm it does not work on my side either using Linux Fedora 40. Is there another way to integrate it to the desktop? I'm a Linux newbie.

brjhaverkamp commented 3 months ago

Same here. Downloaded 8.4.0 just now. But it doesn't integrate. On Ubuntu 24.04

Prakhargarg-2010196 commented 3 months ago

Same here can confirm not working on Ubuntu version 22.04 (jammy)

Area5142 commented 3 months ago

Same here on Linux Mint 21.2 x64 - not working with digiKam-8.4.0-Qt5-x86-64.appimage or digiKam-8.4.0-Qt6-x86-64.appimage.

shmuelie commented 2 months ago

I decided to poke around a bit myself, and the issue is either that the org.kde.shofoto.desktop symlink is invalid or that the desktop files are symlinks at all.

biokomiker commented 2 months ago

Is this your typo or a typo in the app image: It must be showfoto not shofoto ....

shmuelie commented 2 months ago

I copied the name from the appimage so the appimage has the issue

ouinouin commented 2 months ago

same behavior here on linux mint 21.3

ouinouin@ouindell:~$ AppImageLauncher /home/ouinouin/Applications/digiKam-8.4.0-Qt6-x86-64_97532ebe62ba5dabb5109d0c795a129c.appimage 
AppImageLauncher error: appimage_shall_not_be_integrated() failed (returned -1)
AppImageLauncher error: appimage_is_terminal_app() failed (returned -1)

(AppImageLauncher:884361): GLib-CRITICAL **: 12:23:27.767: g_file_test: assertion 'filename != NULL' failed

(AppImageLauncher:884361): GLib-CRITICAL **: 12:23:31.923: g_path_get_basename: assertion 'file_name != NULL' failed

** (AppImageLauncher:884361): CRITICAL **: 12:23:31.923: Failed to find desktop file path

ouinouin commented 1 month ago

also checked on 8.5.0 : this image i got the same result

shmuelie commented 1 month ago

So the typo was fixed in https://invent.kde.org/graphics/digikam/-/commit/3f64a4d05cc600d3d710c8a21b03b4a2dc87381c, meaning that if @ouinouin still had it was the latest builds, that's not it. It then could be from https://invent.kde.org/graphics/digikam/-/commit/f6f74db5b9cc1ce5a7b0552750f3492994447855 which changed to using symlinks instead of putting the desktop files in the root.

RCFNxSVgXK4e commented 1 week ago

@shmuelie you were right.

The bug has been fixed by the lead developer today.

Commit: https://invent.kde.org/graphics/digikam/-/commit/05810c5fc74e1db5b64c9860052158958c3f920e

Tested Version: digiKam-8.5.0-20241115T075906-Qt6-x86-64.appimage

Discussion: https://bugs.kde.org/show_bug.cgi?id=490657

tdog6666 commented 6 days ago

Thanks for addressing this. I can confirm that digiKam-8.5.0-20241115T110110-Qt6-x86-64_650ff5a12d56839c01a62add26324cbc.appimage is now properly integrated into AppImageLauncher on my KDE Neon Plasma desktop, running this config below:

System: Host: KDE-Neon Kernel: 6.8.0-48-generic arch: x86_64 bits: 64 Desktop: KDE Plasma v: 6.2.3 Distro: KDE neon 24.04 6.2 noble

Running x11, not Wayland

TheAssassin / AppImageLauncher