TheAssemblyArmada / Chronoshift

An open source re-implementation of Red Alert written in C++.
GNU General Public License v2.0
171 stars 23 forks source link

Corrections to Queue code. #269

Closed tomsons26 closed 4 years ago

tomsons26 commented 4 years ago

We were using wrong functions in the current code we have that uses the queues.

Operators [] were removed cause the only legal way to fetch in this class is via Fetch_Head and Fetch_From_Head. Operator = was removed cause there should never be a need to do this because these are static buffers. Tail functions don't show in any binary we have and AFAIK fetching the tail and removing the tail would just crash this since it is the tail - the end of the queue, there's nothing there.