search

TheAssemblyArmada / Thyme

An open source re-implementation of Generals : Zero Hour written in C++.
GNU General Public License v2.0
584 stars 59 forks source link

Fix game crash when a shadow buffer limit is exceeded #1101

Open xezon opened 9 months ago

xezon commented 9 months ago

This change fixes game crashes from exceeding the limits of MAX_VB_SIZES, MAX_IB_SIZES and MAX_NUMBER_SLOTS.

MAX_NUMBER_SLOTS is exceeded in the original game when more than 512 Scorpion tanks are rendered in the scene.

codecov-commenter commented 9 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (cfa005f) 2.53% compared to head (6e21d1b) 2.53%.

Files Patch % Lines
...tform/w3dengine/client/shadow/w3dbuffermanager.cpp 0.00% 8 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1101 +/- ## =========================================== - Coverage 2.53% 2.53% -0.01% =========================================== Files 949 949 Lines 110299 110307 +8 Branches 18881 18885 +4 =========================================== Hits 2800 2800 - Misses 107095 107103 +8 Partials 404 404 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.