search

TheAssemblyArmada / Thyme

An open source re-implementation of Generals : Zero Hour written in C++.
GNU General Public License v2.0
584 stars 59 forks source link

Refactor condition tests in shadow related code #1102

Open xezon opened 9 months ago

xezon commented 9 months ago

This change refactors some conditions in shadow related code to match our guidelines.

It does not change functionality.

codecov-commenter commented 9 months ago

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (cfa005f) 2.53% compared to head (5fd6a95) 2.53%.

Files Patch % Lines
src/w3d/renderer/dx8vertexbuffer.cpp 0.00% 16 Missing :warning:
...orm/w3dengine/client/shadow/w3dprojectedshadow.cpp 0.00% 10 Missing :warning:
...tform/w3dengine/client/shadow/w3dbuffermanager.cpp 0.00% 2 Missing :warning:
...rm/w3dengine/client/shadow/w3dvolumetricshadow.cpp 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1102 +/- ## ======================================== Coverage 2.53% 2.53% ======================================== Files 949 949 Lines 110299 110299 Branches 18881 18881 ======================================== Hits 2800 2800 Misses 107095 107095 Partials 404 404 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.