search

TheAssemblyArmada / Thyme

An open source re-implementation of Generals : Zero Hour written in C++.
GNU General Public License v2.0
569 stars 54 forks source link

Speed up compilation with Visual Studio #1115

Closed xezon closed 7 months ago

xezon commented 7 months ago

This change speeds up compilation with Visual Studio.

Tested on CPU: 8 Cores, 16 Threads

Compile time in Debug configuration:

Status Quo

Visual Studio 2019 : 390s

This change

Visual Studio 2019 : 56s Visual Studio 2022 : 50s

+600% Compile speed

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cfa005f) 2.53% compared to head (0219fd4) 2.53%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1115 +/- ## ======================================== Coverage 2.53% 2.53% ======================================== Files 949 949 Lines 110299 110299 Branches 18881 18881 ======================================== Hits 2800 2800 Misses 107095 107095 Partials 404 404 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jonwil commented 7 months ago

Looks good to me. Approved.