Avoid stlport compile error with Visual Studio 2022

TheAssemblyArmada / Thyme

An open source re-implementation of Generals : Zero Hour written in C++.

GNU General Public License v2.0

569 stars 54 forks source link

Avoid stlport compile error with Visual Studio 2022 #1116

Closed xezon closed 7 months ago

xezon commented 7 months ago

This change ~~fixes~~ avoids stlport compile error with Visual Studio 2022.

xstddef file does not exist in Visual Studio 2022. It does exist in Visual Studio 2019 however. But Visual Studio 2019 also compiles without xstddef included in exception from stlport.

Unclear what is going on.

Visual Studio 2019: _STLP_MSVC = 1929
Visual Studio 2022: _STLP_MSVC = 1938

This include was already touched prior with 9d9908f3a28a9b46a25c216b41fc43bb383b740b

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d310f50) 2.53% compared to head (8c89a10) 2.53%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #1116 +/- ## ======================================== Coverage 2.53% 2.53% ======================================== Files 949 949 Lines 110299 110299 Branches 18881 18881 ======================================== Hits 2800 2800 Misses 107095 107095 Partials 404 404 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xezon commented 7 months ago

Yes if some platform needs this explicitly then we compile it in for just that.