search

TheAssemblyArmada / Thyme

An open source re-implementation of Generals : Zero Hour written in C++.
GNU General Public License v2.0
584 stars 59 forks source link

Revert "Remove always.h from hot include files to reduce compile time" #1119

Closed xezon closed 8 months ago

xezon commented 8 months ago

This reverts commit 30cc43174d879316e312a6905720fb87ba801ce1.

It broke string class because of missing PLATFORM_WINDOWS define.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d5484cf) 2.53% compared to head (277e86b) 2.53%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1119 +/- ## ======================================== Coverage 2.53% 2.53% ======================================== Files 949 949 Lines 110299 110299 Branches 18881 18881 ======================================== Hits 2800 2800 Misses 107095 107095 Partials 404 404 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.