search

TheAssemblyArmada / Thyme

An open source re-implementation of Generals : Zero Hour written in C++.
GNU General Public License v2.0
584 stars 59 forks source link

Fix broken attack of GLA Bomb Truck #1127

Closed psykana closed 7 months ago

psykana commented 7 months ago

Fixes #888.

Weapon templates from #888 (IDs 1265 and 1267) don't damage enemies directly, but rather kill themselves and deal damage with Object::On_Die effects. Due to an incorrect coordinate here (probably a typo), damage doesn't apply and nothing happens.

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 2.53%. Comparing base (54999d2) to head (84f7b30).

Files Patch % Lines
src/game/logic/object/weapon.cpp 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1127 +/- ## ======================================== Coverage 2.53% 2.53% ======================================== Files 949 949 Lines 110747 110747 Branches 18995 18995 ======================================== Hits 2802 2802 Misses 107542 107542 Partials 403 403 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.