Fix UI tooltips - Githubissues

TheAssemblyArmada / Thyme

An open source re-implementation of Generals : Zero Hour written in C++.

GNU General Public License v2.0

587 stars 60 forks source link

Closed psykana closed 3 months ago

psykana commented 3 months ago

Radio button, checkbox, slider gadgets set their tooltips here: https://github.com/TheAssemblyArmada/Thyme/blob/b7a373aa62cca0b30f96284a9cbb3e3da9f31545/src/game/client/gui/gamewindowmanager.cpp#L769-L774 Since GameWindow ctor incorrectly initialized window->m_tooltip to a stub function, Thyme never got past the first check.

That didn't fix comboboxes though, which led me to GameWindowManager::Is_Hidden().

Fixes #1138 Fixes #998

jonwil commented 3 months ago

Changes in GameWindowManager::Is_Hidden are correct.