Units stop moving in Replay playback

TheAssemblyArmada / Thyme

An open source re-implementation of Generals : Zero Hour written in C++.

GNU General Public License v2.0

579 stars 57 forks source link

Units stop moving in Replay playback #466

Open xezon opened 2 years ago

xezon commented 2 years ago

Units stop moving in Replay playback.

Extract test replay file to \Documents\Command and Conquer Generals Zero Hour Data\Replays\ 12_05_22_1v1_OoEExCaL_Leader.zip

Extract test map files to Documents\Command and Conquer Generals Zero Hour Data\Maps [RANK] Snowy Drought v4.zip

Load Replay in game. Press F button to fast forward.

Notice how the produced tanks just pile in the map center. Thyme issue.

tomsons26 commented 2 years ago

Source is NameKeyGenerator Name_To_Key hooks, i can't figure out why

tomsons26 commented 2 years ago

Lots of issues here, namekey issue is the operator used for incrementation of m_key WeaponBonusSet::Parse_Weapon_Bonus_Set_Ptr seems the next source but wouldn't seem the last INI::Load is another, something down its chain of calls it makes from the table GeometryInfo is also a source, fixed 3 so far, pr'd fixes

duncanspumpkin commented 2 years ago

Just to keep this issue updated. Replay still has issues but we have addressed:

NameKeyGenerator issue causing incorrect vet
GeometryInfo issues causing some of the pathing issues

There still appears to be further issues. Possible source of issues is not using fast math and also not using x87 float instructions.