TheAssemblyArmada / Vanilla-Conquer

Vanilla Conquer provides clean, cross-platform builds of the C&C Remastered Collection and the standalone legacy games.
Other
346 stars 52 forks source link

Commonizes IconSet functions #1020

Open tomsons26 opened 3 months ago

tomsons26 commented 3 months ago

This turned into a bit of a mess, don't like all those is CC checks or the various system specific magics...

Looking at IconsetClass that was in compat.h, maybe a better way is to create two classes with a singleton static instance, then on game init check a single tile, find out what type it is and use the appropriate class, not sure.

At any rate this still is better as there were unseen direct struct member accesses before.