search

TheAssemblyArmada / Vanilla-Conquer

Vanilla Conquer provides clean, cross-platform builds of the C&C Remastered Collection and the standalone legacy games.
Other
331 stars 51 forks source link

[RA]Add support for extra theaters #269

Open mvdhout1992 opened 3 years ago

mvdhout1992 commented 3 years ago

Should be done via rules.ini or theaters.ini

Note the game checks specific bytes in theater art files to see if the theater byte in the art file matches the current theater. If it doesn't the art file isn't loaded. See this ASM file for more info:

https://github.com/mvdhout1992/ra303p-iran/blob/master/src/extra_theaters.asm

We don't have any tools to modify these bytes in the art files so I support just removing the checks.

Note that there are also theater specific palettes and the Chrono vortex palette that need to be supported.

OmniBlade commented 3 years ago

Can you find the byte check in the source code as I've never come across that when working on the tile parsing code. There are flags set on the terrain types that determine which theatre they are valid for though IIRC.

mvdhout1992 commented 3 years ago

They're patched out in the ASM file I linked.

Op do 24 dec. 2020 om 11:27 schreef OmniBlade notifications@github.com:

Can you find the byte check in the source code as I've never come across that when working on the tile parsing code. There are flags set on the terrain types that determine which theatre they are valid for though IIRC.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TheAssemblyArmada/Vanilla-Conquer/issues/269#issuecomment-750839030, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADCKLQ7OQNE7S7HJGU6VJTSWMJRFANCNFSM4VEEAZHQ .

mvdhout1992 commented 3 years ago

The ASM file has the function names that are patched, I forgot to say.