TheAssemblyArmada / Vanilla-Conquer

Vanilla Conquer provides clean, cross-platform builds of the C&C Remastered Collection and the standalone legacy games.
Other
354 stars 54 forks source link

[RA]In certain expansion missions Turkey (Allies house) is used as Soviet house, on the score screen Turkey is counted under Allies casualties #295

Open mvdhout1992 opened 3 years ago

mvdhout1992 commented 3 years ago

That's fixed in the CnCNet patch with modified missions files and a patch to change the country of a house in the map file + score screen casualties count calculation update.

But requires modified mission files so a hard-coded check for those missions would be better I assume. Still should add the modding ability. Hard-coded check should check for sha1.

@tomsons26 says Petroglyph added a hard-coded fix for this which uses scenario name rather than sha1. Need to investigate and update the code to use sha1.

hifi commented 3 years ago

Yeah, hardcoding the fix in Vanilla is probably the best way forward. There are already hardcoded things in the original code as well for mission overrides so maybe we can just expand that hack/patch list.