[RA] Visual Control Brightness text uppercase

TheAssemblyArmada / Vanilla-Conquer

Vanilla Conquer provides clean, cross-platform builds of the C&C Remastered Collection and the standalone legacy games.

Other

349 stars 52 forks source link

[RA] Visual Control Brightness text uppercase #492

Open JohnsterID opened 3 years ago

JohnsterID commented 3 years ago

ra95demo

In Visual Controls, Brightness is all uppercase, different to the rest of the options.

hifi commented 3 years ago

This seems to be a data issue:

https://github.com/TheAssemblyArmada/Vanilla-Conquer/blob/d8000c09a5f20736de5cf8f2d5e80d8c6b16a90a/redalert/conquer.h#L70

The comment shows the English text that is expected as the result of a string search.

We can fix this properly when we implement our own translation system but until then it will require data patching. The retail game and demo on Windows should inhibit the same issue as far as I understand.

mvdhout1992 commented 3 years ago

Does the original game have this BRIGHTNESS slider?

We could hack fix it in the mean time by removing the uppercase from the non-first characters.