search

TheAssemblyArmada / Vanilla-Conquer

Vanilla Conquer provides clean, cross-platform builds of the C&C Remastered Collection and the standalone legacy games.
Other
346 stars 52 forks source link

pragma warning(disable) is only valid for MSVC #981

Closed th-otto closed 3 months ago

OmniBlade commented 6 months ago

I'd be inclined to remove them entirely from the code base as they are MSVC only and you can turn off warnings from the command line on newer MSVC anyhow.

th-otto commented 6 months ago

I agree, but that is currently not done in the CI builds and/or in CMakeLists.txt, and i did not want do break those builds or clutter them suddenly with lots of warnings.

If you want me to change it to entirely remove them, pls let me know.

OmniBlade commented 6 months ago

746 is intended to move the configuration of warnings out to a preset file that is used for the CI builds which would then allow removing these pragmas from the code base, but its very old as I'm not keen on just merging my own work without having it looked over by another maintainer.