TheAxeDude / ZiniGo

Utility to backup magazines from the Zinio service as PDF, bypassing/Removing their DRM.
MIT License
51 stars 9 forks source link

10 issue limitation? #8

Closed dzavelson closed 3 years ago

dzavelson commented 3 years ago

I was able to download for 10 issues in my library, but then the app stops. My Zinio library probably has close to 100 issues, so I'm not sure why its stopping at 10. When the app runs it says "Found 10 issues in library." I also tried to "archive" within Zinio all of the newest issues that were already downloaded to see if it might then catch the next 10 most recent. But it still only sees 10 and says those issues were already downloaded and found.

TheAxeDude commented 3 years ago

Hi,

I dont have 10 issues yet, so haven't encountered the issue. I will do some digging.

dzavelson commented 3 years ago

Sounds good. Happy to help troubleshoot if you want to check using my larger library.

mugurelu commented 3 years ago

When you fetch the list of issues in GetLibrary, you need to append ?limit=XXX on the link, to fetch a bigger chunk. This issue probably manifests only on big libraries.

Not sure of there's a maximum number, I tried with 240 in my case and it got the entire library. That if you want to get everything in one go.

It's also possible to have pagination, zinio is using via web something like: ?limit=120&page=1&from_date=2021-01-10%2012:54:47

TheAxeDude commented 3 years ago

Aha!

Thanks. I was waiting for my subscription to exceed 10 issues at the end of the month.

I'll modify to go through all the items asap. Thanks for the help!

On Sun, 10 Jan 2021, 16:57 Mugurel Tudor, notifications@github.com wrote:

When you fetch the list of issues in GetLibrary, you need to append ?limit=XXX on the link, to fetch a bigger chunk. This issue probably manifests only on big libraries.

Not sure of there's a maximum number, I tried with 240 in my case and it got the entire library.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/TheAxeDude/ZiniGo/issues/8#issuecomment-757489881, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEL5UR4PGLAZFPNUL3HYZLSZG54HANCNFSM4VGATZCA .

TheAxeDude commented 3 years ago

@mugurelu Can you confirm that passing limit=0 returns all of your issues? Might be an easier way than paginating. On my library it still returns all issues.

mugurelu commented 3 years ago

@TheAxeDude just tested now, limit=0 gets only the most recent 10 issues.

TheAxeDude commented 3 years ago

Ah, thanks for trying. I will work on going the paginated route then :-)

TheAxeDude commented 3 years ago

Have put in a quickfix for the issue, on https://github.com/TheAxeDude/ZiniGo/tree/master/built.

It will fetch issues in batches of 120 (same as the website) until none are returned.

dzavelson commented 3 years ago

Thanks! Seems to be working for me now. Up to 19 issues now and still going.

TheAxeDude commented 3 years ago

Success! Glad it's working.